Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: improve kubeadm command output #79369

Merged
merged 1 commit into from
Jul 3, 2019
Merged

kubeadm: improve kubeadm command output #79369

merged 1 commit into from
Jul 3, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jun 25, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
kubeadm: improve kubeadm command output

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1627
Ref: #79267

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/cc @luxas @neolit123 @rosti

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

@SataQiu: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 25, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Jun 25, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2019
Klaven
Klaven reviewed Jun 26, 2019
View reviewed changes
Copy link
Contributor

@Klaven Klaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I did a few quick greps and did not see anything else to change! thanks!

luxas
luxas approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 26, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 26, 2019
timothysc
timothysc approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, SataQiu, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

cc @kubernetes/patch-release-team

@SataQiu
Copy link
Member Author

SataQiu commented Jul 2, 2019

PTAL @kubernetes/patch-release-team

@aleksandra-malinowska aleksandra-malinowska added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0b72ca4 into kubernetes:release-1.15 Jul 3, 2019
@dixudx dixudx mentioned this pull request Jul 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaven Klaven Klaven left review comments

@timothysc timothysc timothysc approved these changes

@neolit123 neolit123 neolit123 approved these changes

@luxas luxas luxas approved these changes

@rosti rosti Awaiting requested review from rosti

Assignees

@timothysc timothysc

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SataQiu @k8s-ci-robot @neolit123 @timothysc @luxas @Klaven @aleksandra-malinowska