Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add kubectl docs to kubectl staging #79396

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Re-add kubectl docs to kubectl staging #79396

merged 1 commit into from
Jun 28, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 25, 2019

  • Re-adds the kubectl documentation by adding to kubectl staging.
  • Adds the kubectl book

/sig cli
/area kubectl
/kind documentation

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 25, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 25, 2019

/cc @pwittrock
/cc @soltysh
/uncc @rootfs

@k8s-ci-robot k8s-ci-robot requested review from pwittrock and soltysh and removed request for rootfs June 25, 2019 23:32
@seans3
Copy link
Contributor Author

seans3 commented Jun 25, 2019

/cc @Liujingfang1

@seans3
Copy link
Contributor Author

seans3 commented Jun 26, 2019

/retest

1 similar comment
@seans3
Copy link
Contributor Author

seans3 commented Jun 26, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Jun 27, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@seans3
Copy link
Contributor Author

seans3 commented Jun 27, 2019

/cc @apelisse

soltysh
soltysh approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 436194a into kubernetes:master Jun 28, 2019
@seans3 seans3 deleted the kubectl-docs branch August 21, 2019 21:52
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79396 from seans3/kubectl-docs
299d369 
Re-add kubectl docs to kubectl staging

Kubernetes-commit: 436194a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@shiywang shiywang Awaiting requested review from shiywang

@pwittrock pwittrock Awaiting requested review from pwittrock

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seans3 @k8s-ci-robot @soltysh