Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/kubectl/validation to staging #79442

Merged
merged 3 commits into from
Jun 29, 2019
Merged

Move pkg/kubectl/validation to staging #79442

merged 3 commits into from
Jun 29, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 26, 2019

/kind cleanup
/sig cli
/area kubectl

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubectl release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 26, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 26, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/dependency Issues or PRs related to dependency changes and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 26, 2019
@seans3 seans3 changed the title Move pkg/kubectl/validation to staging [WIP] Move pkg/kubectl/validation to staging Jun 26, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2019
@seans3 seans3 changed the title [WIP] Move pkg/kubectl/validation to staging Move pkg/kubectl/validation to staging Jun 28, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 28, 2019

/cc @soltysh
/uncc @juanvallejo

@k8s-ci-robot k8s-ci-robot requested review from soltysh and removed request for juanvallejo June 28, 2019 18:21
@seans3
Copy link
Contributor Author

seans3 commented Jun 28, 2019

/cc @liggitt

@seans3
Copy link
Contributor Author

seans3 commented Jun 28, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Jun 28, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit a574bd6 into kubernetes:master Jun 29, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
@seans3 seans3 deleted the move-kubectl-validation branch August 21, 2019 21:52
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#79442 from seans3/move-kubectl-validation
d8f3a8b 
Move pkg/kubectl/validation to staging

Kubernetes-commit: a574bd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy Awaiting requested review from mengqiy

@soltysh soltysh Awaiting requested review from soltysh

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seans3 @liggitt @k8s-ci-robot