Simplify checking in getMinTolerationTime

[tedyu]

What type of PR is this?
/kind bug

What this PR does / why we need it:
In getMinTolerationTime (taint_manager.go),

			} else if tolerationSeconds < minTolerationTime || minTolerationTime == -1 {

when tolerationSeconds >= minTolerationTime, even if minTolerationTime has been set in prior iteration (!= -1), the second clause would still be evaluated.

After my PR, the wasteful check doesn't exist.

NONE

[tedyu]

@mborsz
Can you take a look ?

[draveness]

/lgtm
/priority backlog

[tedyu]

ping @bowei for review

[bowei]

Can you couple this with a bugfix? This patch just fixes a single spelling mistake.

[tedyu]

@bowei
Correcting typo alone can be found in git log.
e.g.
#80524

To my knowledge, the underlying code doesn't have bug.

[tedyu]

@bowei

git log | grep typo | wc
    2194   12163   94222

The above is count of typo fixes

[tedyu]

@bowei
In getMinTolerationTime (taint_manager.go),

			} else if tolerationSeconds < minTolerationTime || minTolerationTime == -1 {

I can push up one change which optimizes out the 'minTolerationTime == -1' check by changing initial value for minTolerationTime

Let me know what you think.

[tedyu]

/test pull-kubernetes-integration

[tedyu]

/test pull-kubernetes-e2e-gce-100-performance

[tedyu]

/test pull-kubernetes-e2e-gce-100-performance

[tedyu]

/test pull-kubernetes-e2e-gce-100-performance

[tedyu]

@bowei
We should fix the original condition I listed above because when tolerationSeconds >= minTolerationTime, even if minTolerationTime has been set in prior iteration (!= -1), the second clause would still be evaluated.

After my PR, the wasteful check doesn't exist.

[tedyu]

/test pull-kubernetes-e2e-gce

[tedyu]

@bowei
Can you take another look ?

[bowei]

add test cases in the unit tests for

1. multiple toleration times
2. -1 behavior

[tedyu]

@bowei
Your comment has been addressed.

[bowei]

/lgtm
/approve
/remove-hold

[bowei]

/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/nodelifecycle/OWNERS [bowei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment