Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack/boilerplate: added regex to strip Python shebang #79448

Merged
merged 1 commit into from
Jun 28, 2019
Merged

hack/boilerplate: added regex to strip Python shebang #79448

merged 1 commit into from
Jun 28, 2019

Conversation

falcon78921
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind failing-test

What this PR does / why we need it:

Fixes Prow Build Error:
Boilerplate header is wrong for: /home/prow/go/src/k8s.io/kubernetes/hack/update_owners.py

In regards to #79190

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @falcon78921. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2019
@falcon78921 falcon78921 mentioned this pull request Jun 26, 2019
Merged
@spiffxp
Copy link
Member

spiffxp commented Jun 27, 2019

/ok-to-test
/priority important-soon
/sig testing

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 27, 2019
spiffxp
spiffxp suggested changes Jun 27, 2019
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this, few nits

hack/boilerplate/boilerplate.py Outdated
@@ -102,6 +102,9 @@ def file_passes(filename, refs, regexs):
elif extension == "sh":
p = regexs["shebang"]
(data, found) = p.subn("", data, 1)
elif extension == "py":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull into above if?

elif extension in ["sh", "py"]:

hack/boilerplate/boilerplate.py Outdated
@@ -205,7 +208,7 @@ def get_regexs():
regexs["date"] = re.compile(get_dates())
# strip // +build \n\n build constraints
regexs["go_build_constraints"] = re.compile(r"^(// \+build.*\n)+\n", re.MULTILINE)
# strip #!.* from shell scripts
# strip #!.* from shell scripts & Python scripts too!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# strip #!.* from shell scripts & Python scripts too!
# strip #!.* from scripts

hack/boilerplate: added regex to strip Python shebang
452c7be 
Fixes Prow Build Error:
Boilerplate header is wrong for: /home/prow/go/src/k8s.io/kubernetes/hack/update_owners.py

Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>
@falcon78921
Copy link
Contributor Author

@spiffxp Done :)

@falcon78921
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-e2e-gce-100-performance

@falcon78921
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-100-performance

@spiffxp
Copy link
Member

spiffxp commented Jun 27, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: falcon78921, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@falcon78921
Copy link
Contributor Author

@spiffxp Thanks again! :)

@k8s-ci-robot k8s-ci-robot merged commit e74f75a into kubernetes:master Jun 28, 2019
@falcon78921 falcon78921 deleted the wip-k8s-boilerplate branch June 28, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@eparis eparis Awaiting requested review from eparis

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@falcon78921 @k8s-ci-robot @spiffxp