kubeadm: don't use the Docker SDK in util/system/docker_validator* #79449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/kubeadm
approved
|
/sig node |
k8s-ci-robot
added
the
sig/node
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
andrewsykim
reviewed
Jun 27, 2019
neolit123
force-pushed
the
kubeadm-docker-validator
branch
3 times, most recently
from
bed1a5a
to
9b87f1c
Compare
k8s-ci-robot
added
size/L
neolit123
commented
Jun 27, 2019
| @@ -112,15 +112,7 @@ | |||
| "github.com/coreos/etcd/pkg/tlsutil", | |||
| "github.com/coreos/etcd/pkg/transport", | |||
| "github.com/davecgh/go-spew/spew", | |||
| "github.com/docker/distribution/digestset", | |||
| "github.com/docker/distribution/reference", | |||
There was a problem hiding this comment.
looks like we depend on docker still; possibly due to the ipvs imports [1]
should be updated in separate PRs.
neolit123
commented
Jun 27, 2019
| "github.com/docker/go-connections/nat", | ||
| "github.com/docker/go-connections/sockets", | ||
| "github.com/docker/go-connections/tlsconfig", | ||
| "github.com/docker/go-units", | ||
| "github.com/docker/libnetwork/ipvs", |
There was a problem hiding this comment.
This is mostly pulled to use consts IIRC, I'll send a PR to consolidate our const usage (rbac, kube-proxy etc..)
timothysc
reviewed
Jun 28, 2019
Instead of creating a Docker client and fetching an Info object from the docker enpoint, call the "docker info" command and populate a local dockerInfo struct from JSON output. Also - add unit tests. - update import boss and bazel. This change affects "test/e2e_node/e2e_node_suite_test.go" as it consumes this Docker validator by calling "system.ValidateSpec()".
neolit123
force-pushed
the
kubeadm-docker-validator
branch
from
9b87f1c
to
cb56f91
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
timothysc
approved these changes
Jul 1, 2019
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Instead of creating a Docker client and fetching an Info object
from the Docker enpoint, call the "docker info" command
and populate a local dockerInfo struct from JSON output.
Also add unit tests.
This change affects "test/e2e_node/e2e_node_suite_test.go"
as it consumes this Docker validator by calling
"system.ValidateSpec()".
this decouples the validator and kubeadm from the Docker SDK.
Which issue(s) this PR fixes:
xref kubernetes/kubeadm#1638
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
should not be user facing.
/assign @yastij
@kubernetes/sig-cluster-lifecycle-pr-reviews
cc @dims
/kind cleanup
/priority important-soon