Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes test-cmd inappropriate dependency on kubectl #79490

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Removes test-cmd inappropriate dependency on kubectl #79490

merged 1 commit into from
Jun 28, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 27, 2019

  • Copies test file validPod.yaml to test/fixtures/pkg/kubectl
  • Removes inappropriate dependency of test-cmd on kubectl

/sig cli
/area kubectl
/kind cleanup

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 27, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 27, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 27, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jun 27, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@seans3
Copy link
Contributor Author

seans3 commented Jun 27, 2019

/cc @Liujingfang1

@seans3
Copy link
Contributor Author

seans3 commented Jun 27, 2019

/retest

@apelisse
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8f41397 into kubernetes:master Jun 28, 2019
@seans3 seans3 deleted the remove-kubectl-dep branch August 21, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixudx dixudx Awaiting requested review from dixudx

@ghodss ghodss Awaiting requested review from ghodss

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seans3 @apelisse @k8s-ci-robot