-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate error messages from cli commands #79493
Conversation
Since we never use the cobras "SilenceErrors" or "SilenceUsage", a command executed with "cmd.Execute()" will never return an error without printing it. The current behavior results in all error messages being printed twice: Example: $ kubectl abc Error: unknown command "abc" for "kubectl" Run 'kubectl --help' for usage. unknown command "abc" for "kubectl" This applies to all cli commands using Cobra. To verify, follow the code path of the Execute function: https://github.com/spf13/cobra/blob/c439c4fa0937/command.go#L793 Signed-off-by: Odin Ugedal <odin@ugedal.com>
Hi @odinuge. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @BenTheElder |
/assign @apelisse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/ok-to-test
/priority backlog |
OK It doesn't look like we're using /lgtm |
From 😄 |
/test pull-kubernetes-dependencies |
belated LGTM 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, neolit123, odinuge, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this something we want to cherry-pick into previous releases? The bug is quite annoying, and the fix is very simple.. Eg. this: $ kubeadm ini
Error: unknown command "ini" for "kubeadm"
Did you mean this?
init
Run 'kubeadm --help' for usage.
error: unknown command "ini" for "kubeadm"
Did you mean this?
init |
@odinuge good question, raised to #sig-release on slack 😅 |
Ahh, good idea! Didn't think about asking on slack 😄 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Since we never use the cobras "SilenceErrors" or "SilenceUsage",
a command executed with "cmd.Execute()" will never return an error
without printing it.
The current behavior results in all error messages being printed twice:
Example:
This applies to all cli commands using Cobra. To verify, follow the code
path of the Execute function:
https://github.com/spf13/cobra/blob/c439c4fa0937/command.go#L793
/sig cli
Which issue(s) this PR fixes:
Fixes #79454
Special notes for your reviewer:
Does this PR introduce a user-facing change?: