Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unit test to pass on machines without ipv6 #79575

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Allow unit test to pass on machines without ipv6 #79575

merged 1 commit into from
Jul 1, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jun 30, 2019

Fixes pull-kubernetes-bazel-test: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79182/pull-kubernetes-bazel-test/1145354074598674432/
Ref: #79182

Like #79537, but for release-1.14.

/assign @liggitt

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 30, 2019
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 30, 2019
@nikhita nikhita mentioned this pull request Jun 30, 2019
Merged
@nikhita
Copy link
Member Author

nikhita commented Jun 30, 2019

/kind failing-test
/priority critical-urgent

/cc @feiskyer @hoegaarden

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 30, 2019
@feiskyer
Copy link
Member

feiskyer commented Jul 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2019
@hoegaarden
Copy link
Contributor

/assign @kubernetes/sig-api-machinery-pr-reviews
/lgtm

@liggitt
Copy link
Member

liggitt commented Jul 1, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2019
@hoegaarden hoegaarden added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 1, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit c5a761c into kubernetes:release-1.14 Jul 1, 2019
@nikhita nikhita deleted the ipv6-unit-test-fix branch July 2, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@ncdc ncdc Awaiting requested review from ncdc

@feiskyer feiskyer Awaiting requested review from feiskyer

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

Assignees

@feiskyer feiskyer

@liggitt liggitt

@hoegaarden hoegaarden

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nikhita @feiskyer @hoegaarden @liggitt @k8s-ci-robot