Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate scalability tests (we use ClusterLoader already) #79588

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Deprecate scalability tests (we use ClusterLoader already) #79588

merged 1 commit into from
Jul 1, 2019

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Jul 1, 2019

@kubernetes/sig-scalability-misc @shyamjvs

@wojtek-t wojtek-t requested a review from shyamjvs July 1, 2019 06:22
@k8s-ci-robot
Copy link
Contributor

@wojtek-t: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2019
@k8s-ci-robot k8s-ci-robot requested a review from gmarek July 1, 2019 06:24
@wojtek-t wojtek-t mentioned this pull request Jul 1, 2019
Closed
@wojtek-t wojtek-t added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 1, 2019
mm4tt
mm4tt reviewed Jul 1, 2019
View reviewed changes
test/e2e/scalability/density.go Outdated
@@ -14,6 +14,14 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

// DEPRECATED.
// We already migrated all periodic and presubmit tests to ClusterLoader.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a question than change request.
There seems to be confusion between ClusterLoader and ClusterLoader2, I think we commonly refer to ClusterLoader2 as ClusterLoader, even though there exists thing like ClusterLoader and it's something else than ClusterLoader2.
Should we get rid (or deprecate) of ClusterLoader to make things clear or is it still used somewhere / by someone?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to make explicit that we refer to ClusterLoader2.

I agree we should deprecate ClusterLoader - this was originally open-sources by Redhat, so we should probably talk with them though.

@wojtek-t wojtek-t force-pushed the deprecate_scalability_tests branch from b3c7326 to dcd064a Compare July 1, 2019 07:15
@wojtek-t
Copy link
Member Author

wojtek-t commented Jul 1, 2019

/retest

mm4tt
mm4tt reviewed Jul 1, 2019
View reviewed changes
Copy link
Contributor

@mm4tt mm4tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@wojtek-t
Copy link
Member Author

wojtek-t commented Jul 1, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8756e2c into kubernetes:master Jul 1, 2019
@wojtek-t wojtek-t deleted the deprecate_scalability_tests branch July 5, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt left review comments

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@mm4tt mm4tt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wojtek-t @k8s-ci-robot @fejta-bot @mm4tt