Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace KubeDescribe with ginkgo.Describe in e2e/kubectl #79910

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Replace KubeDescribe with ginkgo.Describe in e2e/kubectl #79910

merged 1 commit into from
Aug 23, 2019

Conversation

k-toyoda-pi
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Currently, almost all e2e tests do not use KubeDescribe function but use ginkgo.Describe or SIGDescribe.
KubeDescribe adds [k8s.io] prefix, however the prefix is not necessary from modification of #50054.
Some e2e tests use KubeDescribe, that makes reader confusing why it uses KubeDescribe or other functions of description.

This PR replaces KubeDescribe with ginkgo.Describe in e2e/kubectl.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 9, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims and rootfs July 9, 2019 00:39
@k-toyoda-pi
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

@dims
Copy link
Member

dims commented Jul 9, 2019

/uncc
/assign @deads2k

@k8s-ci-robot k8s-ci-robot removed the request for review from dims July 9, 2019 13:41
@oomichi
Copy link
Member

oomichi commented Aug 14, 2019

This makes e2e tests readable like

- [sig-cli] Kubectl Port forwarding [k8s.io] With a server listening on 0.0.0.0 [k8s.io] that expects NO client request should support a client that connects, sends DATA, and disconnects
+ [sig-cli] Kubectl Port forwarding With a server listening on 0.0.0.0 that expects NO client request should support a client that connects, sends DATA, and disconnects

by removing [k8s.io] tag as #50054
so

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2019
@k-toyoda-pi
Copy link
Contributor Author

@deads2k Could you review and approve this PR?

@oomichi
Copy link
Member

oomichi commented Aug 22, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k-toyoda-pi, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2019
@oomichi
Copy link
Member

oomichi commented Aug 22, 2019

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8bf4bdc into kubernetes:master Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 23, 2019
@k-toyoda-pi k-toyoda-pi deleted the replace_KubeDescribe_e2e_kubectl branch August 26, 2019 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@oomichi oomichi

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@k-toyoda-pi @dims @oomichi @k8s-ci-robot @fejta-bot @deads2k