Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NodeLister from Scheduler Configurator #80233

Merged
merged 3 commits into from Jul 30, 2019
Merged

Remove NodeLister from Scheduler Configurator #80233

merged 3 commits into from Jul 30, 2019
+22 −36

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Jul 16, 2019 •
edited

/kind cleanup

The NodeLister from the Configurator is no longer used in runtime code, so tests shouldn't use it either. Use the lister from Config instead

Which issue(s) this PR fixes:
First tackle on #80216

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @alculquicondor. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 16, 2019
@alculquicondor
Copy link
Member Author

/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 16, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2019
@ahg-g
Copy link
Member

ahg-g commented Jul 23, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
@alculquicondor
Copy link
Member Author

/test pull-kubernetes-typecheck
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2019
@alculquicondor
Remove NodeLister from Scheduler Configurator
8e9af01 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor
Store config args instead of config factory in test context
0ce1c95 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2019
@alculquicondor
Copy link
Member Author

/hold cancel

Parent PR was merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2019
@alculquicondor alculquicondor mentioned this pull request Jul 24, 2019
Closed
6 tasks
wgliang
wgliang suggested changes Jul 25, 2019
View reviewed changes
pkg/scheduler/factory/factory.go Outdated
@@ -153,8 +153,6 @@ type Configurator interface {
GetClient() clientset.Interface

// TODO(#80216): Remove these methods from the interface.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can TODO be deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. GetScheduledPodLister can be removed as well, but it requires more changes. Maybe GetClient too. I hape a WIP.

@alculquicondor
Update TODO
0e35ac8 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@ahg-g
Copy link
Member

ahg-g commented Jul 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@alculquicondor alculquicondor mentioned this pull request Jul 25, 2019
Merged
@ahg-g
Copy link
Member

ahg-g commented Jul 26, 2019

@Huang-Wei can you please take another look?

Huang-Wei
Huang-Wei reviewed Jul 29, 2019
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks, @alculquicondor.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d248bd0 into kubernetes:master Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@draveness draveness draveness left review comments

@ahg-g ahg-g ahg-g left review comments

@wgliang wgliang wgliang requested changes

@resouer resouer Awaiting requested review from resouer

Assignees

@Huang-Wei Huang-Wei

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alculquicondor @k8s-ci-robot @ahg-g @fejta-bot @Huang-Wei @draveness @wgliang