New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the TopologyManager socketmask abstraction #80315
Cleanup the TopologyManager socketmask abstraction #80315
Conversation
Hi @klueska. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/priority backlog
78e0ca3
to
65b0731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @tallclair
/test pull-kubernetes-kubemark-e2e-gce-big |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorDoyle, klueska The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@klueska: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds package level commands for
And
andOr
to theTopologyManager
socketmask
abstraction. It also adds a newNewEmtpySocketMask()
call to the API, so we can create empty socket masks that don't return anerror
. Finally, it cleans up the comments to make them more in line with go conventions.The combination of the package level
And
andOr
calls, together with theNewEmtpySocketMask()
call will help to cleanup some of the code in the places where these socket masks are used.Follow-up PRs will be created to address these.
Does this PR introduce a user-facing change?: