Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example urls #80356

Merged
merged 1 commit into from Aug 6, 2019
Merged

Fix example urls #80356

merged 1 commit into from Aug 6, 2019

Conversation

liangxia
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
The old urls link to 404 page

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @liangxia. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 19, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

draveness
draveness reviewed Jul 19, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old links were moved to kubernetes/examples in #46362.

Do we have some other URLs which could redirect to kubernetes/examples GitHub page?

/ok-to-test
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 19, 2019
@liangxia
Copy link
Contributor Author

Do we have some other URLs which could redirect to kubernetes/examples GitHub page?

@draveness
Using examples.k8s.io now.

draveness
draveness approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @liangxia

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@liangxia
Copy link
Contributor Author

/retest

@liangxia
Copy link
Contributor Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Jul 25, 2019

asked in kubernetes/examples#334 why the staging directory exists in the examples repo. wanted to get clarity on that before we go updating links to it in API docs

@liggitt
Copy link
Member

liggitt commented Jul 30, 2019

based on kubernetes/examples#334 (comment), before updating links to point into the staging dir, the relevant examples should be promoted out of the staging dir

@liangxia liangxia mentioned this pull request Jul 31, 2019
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2019
@liangxia
Copy link
Contributor Author

liangxia commented Aug 1, 2019

@draveness @liggitt The PR is ready for review (addressed issue in comments).

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2019
@liangxia
Copy link
Contributor Author

liangxia commented Aug 5, 2019

Rebased.

@liggitt
Copy link
Member

liggitt commented Aug 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@liangxia
Copy link
Contributor Author

liangxia commented Aug 6, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit b1ffa38 into kubernetes:master Aug 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 6, 2019
@liangxia liangxia deleted the fix-example-url branch August 6, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draveness draveness draveness approved these changes

@eparis eparis Awaiting requested review from eparis

@luxas luxas Awaiting requested review from luxas

Assignees

@liggitt liggitt

@draveness draveness

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liangxia @k8s-ci-robot @fejta-bot @liggitt @draveness