Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default PVC AccessModes to RWO in test framework #80377

Merged
merged 1 commit into from Jul 23, 2019
Merged

Change default PVC AccessModes to RWO in test framework #80377

merged 1 commit into from Jul 23, 2019

Conversation

davidz627
Copy link
Contributor

AccessModes on the PVC specify the union of all modes the volume provisioned in the PV must support. This means the default request for PVC is requesting a volume with all RWO, ROX, RWX which is not supported by many volumes so does not seem like a sensible default.

Changing it to RWO, a minimal, standard access mode required for the provisioner to satisfy seems like a more sensible default. If the plugin/driver wants to test specifically setting more/different access modes they can pass in a config.

Since this is changing defaulting behavior this might affect tests. This might break some NFS tests but it's my assertion that if that happens it is a bug in the NFS provisioner code not the fault of the defaulting since the access modes specified in this change is a strict subset of the old union of accessmodes.

/kind bug
/kind failing-test
/sig storage
/priority important-soon
/assign @msau42 @jsafrane
/cc @mkimuram

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 19, 2019
@davidz627
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@jsafrane jsafrane mentioned this pull request Jul 22, 2019
Merged
@msau42
Copy link
Member

msau42 commented Jul 22, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, jsafrane, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@davidz627
Copy link
Contributor Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 7dc5d1f into kubernetes:master Jul 23, 2019
@davidz627 davidz627 deleted the fix/testAMDefault branch July 23, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkimuram mkimuram Awaiting requested review from mkimuram

Assignees

@BenTheElder BenTheElder

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@davidz627 @jsafrane @msau42 @k8s-ci-robot @fejta-bot @BenTheElder