Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump smd #80380

Merged
merged 2 commits into from Jul 21, 2019
Merged

Bump smd #80380

merged 2 commits into from Jul 21, 2019

Conversation

lavalamp
Copy link
Member

@lavalamp lavalamp commented Jul 19, 2019 •
edited 

$ benchcmp orig.txt new.txt
benchmark                       old ns/op     new ns/op     delta
BenchmarkApplyNewObject-12      2230683       2129184       -4.55%
BenchmarkUpdateNewObject-12     2624417       2379121       -9.35%
BenchmarkRepeatedUpdate-12      1031653       981264        -4.88%
BenchmarkSetToFields-12         24778         23686         -4.41%
BenchmarkFieldsToSet-12         33876         17971         -46.95%
BenchmarkYAMLToTyped-12         68377         64312         -5.94%

benchmark                       old allocs     new allocs     delta
BenchmarkApplyNewObject-12      8632           7168           -16.96%
BenchmarkUpdateNewObject-12     11210          8396           -25.10%
BenchmarkRepeatedUpdate-12      3057           2887           -5.56%
BenchmarkSetToFields-12         124            124            +0.00%
BenchmarkFieldsToSet-12         147            93             -36.73%
BenchmarkYAMLToTyped-12         150            152            +1.33%

benchmark                       old bytes     new bytes     delta
BenchmarkApplyNewObject-12      555847        500704        -9.92%
BenchmarkUpdateNewObject-12     659671        560262        -15.07%
BenchmarkRepeatedUpdate-12      255150        221120        -13.34%
BenchmarkSetToFields-12         8974          8369          -6.74%
BenchmarkFieldsToSet-12         12897         4688          -63.65%
BenchmarkYAMLToTyped-12         27625         27384         -0.87%

NONE

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 19, 2019
@lavalamp
Copy link
Member Author

/sig api-machinery
/kind feature
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 19, 2019
@lavalamp
Copy link
Member Author

/assign @jennybuckley @apelisse

@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jul 19, 2019
@k8s-ci-robot k8s-ci-robot requested review from cheftako, dchen1107 and a team July 19, 2019 22:57
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2019
@BenTheElder
Copy link
Member

/retest

apelisse
apelisse reviewed Jul 21, 2019
View reviewed changes
Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clearly better :-)

staging/src/k8s.io/apiextensions-apiserver/go.sum
@@ -310,7 +310,7 @@ modernc.org/strutil v1.0.0/go.mod h1:lstksw84oURvj9y3tn8lGvRxyRC1S2+g5uuIzNfIOBs
modernc.org/xc v1.0.0/go.mod h1:mRNCo0bvLjGhHO9WsyuKVU4q0ceiDDDoEeWDJHrNx8I=
sigs.k8s.io/structured-merge-diff v0.0.0-20190525122527-15d366b2352e h1:4Z09Hglb792X0kfOBBJUPFEyvVfQWrYT/l8h5EKA6JQ=
sigs.k8s.io/structured-merge-diff v0.0.0-20190525122527-15d366b2352e/go.mod h1:wWxsB5ozmmv/SG7nM11ayaAW51xMvak/t1r0CSlcokI=
sigs.k8s.io/structured-merge-diff v0.0.0-20190628201129-059502f64143 h1:9df9ZMJ21XLKSCuwZyI+qfbnQl/hDmrM7wjBK85iv8g=
sigs.k8s.io/structured-merge-diff v0.0.0-20190628201129-059502f64143/go.mod h1:wWxsB5ozmmv/SG7nM11ayaAW51xMvak/t1r0CSlcokI=
sigs.k8s.io/structured-merge-diff v0.0.0-20190719182312-e94e05bfbbe3 h1:yCY9zAYErawYwXdOYmwEBzcGCr/6eIUujYZE2DIQve8=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not new in this PR, but I'm curious why we end-up with 4 lines for smd, @liggitt

@apelisse
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c2a4369 into kubernetes:master Jul 21, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse apelisse left review comments

@cheftako cheftako Awaiting requested review from cheftako

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@apelisse apelisse

@jennybuckley jennybuckley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lavalamp @BenTheElder @apelisse @k8s-ci-robot @liggitt @jennybuckley