Handle NotImplemented error in service_controller. #80660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/cloudprovider
sig/apps
|
/assign @bowei |
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
the
lgtm
|
/retest |
cheftako
reviewed
Jul 29, 2019
| @@ -339,6 +339,10 @@ func (s *ServiceController) syncLoadBalancerIfNeeded(service *v1.Service, key st | |||
| } | |||
| newStatus, err = s.ensureLoadBalancer(service) | |||
| if err != nil { | |||
| if err == cloudprovider.NotImplemented { | |||
There was a problem hiding this comment.
The NotImplemented error is an already existing error which cloud providers outside of tree may be using. I do not think we should ignore it here. If we want an error to indicate the functionality is implemented elsewhere lets generate a new error for that case.
There was a problem hiding this comment.
ack, will add a new error.
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/XL
Adding a new error "ImplementedElsewhere" to cloud.go. This error indicates that implementation for a particular service/loadbalancer spec is handled by a different controller. The caller can ignore the error and skip modifying service status upon receiving this error.
Added error check to EnsureLoadBalancerDeleted.
Depending on how the cluster is created. Test clusters set a default level of 4.
Removed handling ImplementedElsewhere error in call to EnsureLoadBalancerDeleted.
bowei
reviewed
Aug 2, 2019
| @@ -339,6 +339,11 @@ func (s *ServiceController) syncLoadBalancerIfNeeded(service *v1.Service, key st | |||
| } | |||
| newStatus, err = s.ensureLoadBalancer(service) | |||
| if err != nil { | |||
| if err == cloudprovider.ImplementedElsewhere { | |||
| klog.V(4).Infof("LoadBalancer for service %s implemented by a different controller %s, Ignoring error", | |||
There was a problem hiding this comment.
minor: we usually don't break newline inside statement.
bowei
reviewed
Aug 2, 2019
| @@ -703,7 +708,12 @@ func (s *ServiceController) lockedUpdateLoadBalancerHosts(service *v1.Service, h | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| if err == cloudprovider.ImplementedElsewhere { | |||
| // ImplementedElsewhere indicates that the UpdateLoadBalancer is a nop and the | |||
There was a problem hiding this comment.
Don't you need the comment above as well.
|
/ok-to-test |
k8s-ci-robot
added
lgtm
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/approve |
cheftako
approved these changes
Aug 3, 2019
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, cheftako, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR adds support in service_controller to handle NotImplemented errors when creating a LoadBalancer. CloudProviders using alternate controllers to implement LoadBalancer services or choosing to skip creation of LoadBalancer based on service annotations can now return a NotImplemented error. service_controller will ignore the error without generating an event and will also not modify the Service status in any way.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: