Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/kubectl/generate to staging #80679

Merged
merged 1 commit into from Jul 31, 2019
Merged

Move pkg/kubectl/generate to staging #80679

merged 1 commit into from Jul 31, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jul 28, 2019

/kind cleanup
/sig cli
/area kubectl
/area code-organization
/priority important-soon

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/code-organization Issues or PRs related to kubernetes code organization priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 28, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2019
@dims
Copy link
Member

dims commented Jul 29, 2019

/approve
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jul 29, 2019

/assign @dims

for hack/.golint_failures and vendor/modules.txt

@liggitt
Copy link
Member

liggitt commented Jul 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2019
@dims
Copy link
Member

dims commented Jul 30, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Jul 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@seans3 seans3 force-pushed the move-generate-staging branch 2 times, most recently from 789eaff to a41f463 Compare July 30, 2019 18:41
@seans3
Copy link
Contributor Author

seans3 commented Jul 30, 2019

/retest

2 similar comments
@seans3
Copy link
Contributor Author

seans3 commented Jul 30, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Jul 30, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Jul 30, 2019

/retest

1 similar comment
@seans3
Copy link
Contributor Author

seans3 commented Jul 31, 2019

/retest

BenTheElder
BenTheElder approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit bdde11a into kubernetes:master Jul 31, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 31, 2019
@seans3 seans3 deleted the move-generate-staging branch August 21, 2019 21:51
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#80679 from seans3/move-generate-staging
3874cf7 
Move pkg/kubectl/generate to staging

Kubernetes-commit: bdde11a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dims dims

@BenTheElder BenTheElder

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@seans3 @dims @liggitt @k8s-ci-robot @BenTheElder