Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pkg/kubectl/conditions.go to remove file #80761

Merged
merged 1 commit into from Aug 1, 2019
Merged

Refactor pkg/kubectl/conditions.go to remove file #80761

merged 1 commit into from Aug 1, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jul 30, 2019 •
edited

  • Moves pkg/kubectl/conditions.go functionality to two other files, since these functions are only used in two places.
  • Removes pkg/kubectl/conditions.go file.
  • Helps in the kubectl move to staging by removing a dependency.

/kind cleanup
/sig cli
/area kubectl
/area code-organization
/priority important-soon

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/code-organization Issues or PRs related to kubernetes code organization priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@seans3 seans3 force-pushed the refactor-kubectl-condition branch from 2c3383e to d38280e Compare July 30, 2019 19:53
@seans3
Copy link
Contributor Author

seans3 commented Jul 30, 2019

/retest

4 similar comments
@seans3
Copy link
Contributor Author

seans3 commented Jul 30, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Jul 31, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Jul 31, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Jul 31, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Jul 31, 2019

/assign @Liujingfang1

@seans3
Copy link
Contributor Author

seans3 commented Jul 31, 2019

/retest

1 similar comment
@seans3
Copy link
Contributor Author

seans3 commented Jul 31, 2019

/retest

BenTheElder
BenTheElder approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 31, 2019
@seans3 seans3 force-pushed the refactor-kubectl-condition branch from d38280e to b15290d Compare July 31, 2019 17:27
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 31, 2019
BenTheElder
BenTheElder approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@seans3
Copy link
Contributor Author

seans3 commented Jul 31, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit b7cb64f into kubernetes:master Aug 1, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 1, 2019
@seans3 seans3 deleted the refactor-kubectl-condition branch August 21, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@BenTheElder BenTheElder

@Liujingfang1 Liujingfang1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seans3 @k8s-ci-robot @BenTheElder @Liujingfang1