Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert e2e webhook tests to use v1 API #80769

Merged
merged 2 commits into from Jul 31, 2019
Merged

Convert e2e webhook tests to use v1 API #80769

merged 2 commits into from Jul 31, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 30, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Converts the e2e admissionwebhook tests to register using the v1 API.
  • Fixes a bug in one of the e2e tests that incorrectly tested timeout on a hanging webhook

Which issue(s) this PR fixes:
Part of #80767

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 30, 2019
@liggitt
Copy link
Member Author

liggitt commented Jul 30, 2019

/assign @jpbetz @roycaihw
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 30, 2019
@liggitt liggitt added this to the v1.16 milestone Jul 30, 2019
@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 30, 2019
@liggitt
Copy link
Member Author

liggitt commented Jul 30, 2019

xref #80763
/retest

@liggitt liggitt added this to Required for GA, in progress in Admission Webhooks Jul 31, 2019
@liggitt liggitt requested review from jpbetz, roycaihw and deads2k and removed request for enisoc and saad-ali July 31, 2019 00:11
@liggitt liggitt mentioned this pull request Jul 31, 2019
Merged
@deads2k
Copy link
Contributor

deads2k commented Jul 31, 2019

Looks consistent. Glad the error is being specifically checked now.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 39af3cc into kubernetes:master Jul 31, 2019
@liggitt liggitt deleted the admission-conformance branch August 1, 2019 01:46
@liggitt liggitt moved this from Required for GA, in progress to Complete in Admission Webhooks Aug 2, 2019
@abhinavdahiya abhinavdahiya mentioned this pull request Aug 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@roycaihw roycaihw Awaiting requested review from roycaihw

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@jpbetz jpbetz

@roycaihw roycaihw

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Admission Webhooks
Complete
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @deads2k @jpbetz @roycaihw