Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cacheWatcher#stop #80788

Merged
merged 1 commit into from Aug 2, 2019
Merged

Rename cacheWatcher#stop #80788

merged 1 commit into from Aug 2, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Jul 31, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR renames cacheWatcher#stop as stopThreadUnsafe .
The rename can be done because callers to the stop func have obtained Cacher's lock.

Also removes the locking in this func which is not needed.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 31, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Jul 31, 2019

cc @hormes

@hormes
Copy link
Contributor

hormes commented Aug 1, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@hormes: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tedyu
Copy link
Contributor Author

tedyu commented Aug 1, 2019

@wojtek-t
Can you take a look ?

thanks

@tedyu
Copy link
Contributor Author

tedyu commented Aug 1, 2019

@wojtek-t
Thanks for the thorough comments.

Can you take another look ?

@jennybuckley
Copy link

/cc @jpbetz

@tedyu
Copy link
Contributor Author

tedyu commented Aug 2, 2019

@wojtek-t
Your comment has been addressed.

@wojtek-t
Copy link
Member

wojtek-t commented Aug 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedyu, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 42d7fee into kubernetes:master Aug 2, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@xiang90 xiang90 Awaiting requested review from xiang90

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tedyu @hormes @k8s-ci-robot @jennybuckley @wojtek-t @fejta-bot