Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine watcher count calculation #80792

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Refine watcher count calculation #80792

merged 1 commit into from
Jul 31, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Jul 31, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The TestCacherNoLeakWithMultipleWatchers incorrectly reports the number of leaked watchers because each entry in watchersBuckets has some watchers in the value.

This PR corrects the number of leaked watchers reported.
I also enhance the failure log with the bucket Id where the leak occurred.

Also removes the thread unsafe comment for watcherBookmarkTimeBuckets.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 31, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Jul 31, 2019

cc @hormes

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 31, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Jul 31, 2019

Here is sample failure log:

--- FAIL: TestCacherNoLeakWithMultipleWatchers (5.01s)
    cacher_whitebox_test.go:653: there are 1 watchers at bucket Id 1564509884 with start Id 1564509888
    cacher_whitebox_test.go:655: unexpected bookmark watchers 1
FAIL

@tedyu
Copy link
Contributor Author

tedyu commented Jul 31, 2019

/test pull-kubernetes-e2e-gce

@tedyu
Copy link
Contributor Author

tedyu commented Jul 31, 2019

@wojtek-t
This PR removes the thread unsafe comment.

@wojtek-t wojtek-t self-assigned this Jul 31, 2019
@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedyu, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 27c4ba5 into kubernetes:master Jul 31, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tedyu @wojtek-t @k8s-ci-robot