Wait for pods to be running before eviction starts #80879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/XS
ravisantoshgudimetla
force-pushed
the
fix-taint-manager
branch
from
c7d22c2
to
56643d0
Compare
ravisantoshgudimetla
force-pushed
the
fix-taint-manager
branch
from
56643d0
to
b4ea510
Compare
bsalamat
reviewed
Aug 5, 2019
| @@ -426,6 +427,9 @@ var _ = SIGDescribe("NoExecuteTaintManager Multiple Pods [Serial]", func() { | |||
| pod2.Spec.NodeSelector = map[string]string{"kubernetes.io/hostname": nodeHostNameLabel} | |||
| _, err = testutils.RunPodAndGetNodeName(cs, pod2, 2*time.Minute) | |||
| framework.ExpectNoError(err) | |||
| // Wait for pods to be running state before eviction happens | |||
| framework.ExpectNoError(e2epod.WaitForPodRunningInNamespace(cs, pod1)) | |||
There was a problem hiding this comment.
The name of RunPodAndGetNodeName function is mis-leading. I initially thought we already check that the pods are running, but looks like that function only waits until the pod is scheduled. We should probably rename that function in a separate PR.
There was a problem hiding this comment.
Agreed, will change it in a another PR. Thanks :)
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As of now, we're not exactly waiting for pod to be running before proceeding to check for eviction. Sometimes this might cause races which we're noticing occasionally in OpenShift CI.
/cc @Huang-Wei @bsalamat
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: