Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #80923: Reduce GCE PD Attach Limits by 1 because Node Boot Disk #80927

Merged
merged 1 commit into from Aug 8, 2019
Merged

Automated cherry pick of #80923: Reduce GCE PD Attach Limits by 1 because Node Boot Disk #80927

merged 1 commit into from Aug 8, 2019

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Aug 2, 2019 •
edited

Cherry pick of #80923 on release-1.13.

#80923: Reduce GCE PD Attach Limits by 1 because Node Boot Disk

/kind bug
/sig storage
/priority important-soon
/assign @msau42 @gnufied @jsafrane

Reduces GCE PD Node Attach Limits by 1 since the node boot disk is considered an attachable disk

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 2, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Aug 2, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 2, 2019
@msau42
Copy link
Member

msau42 commented Aug 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2019
@hantaowang
Copy link

/retest

@tpepper
Copy link
Member

tpepper commented Aug 6, 2019

@msau42 looks like for this particular one of the three CP's we need @saad-ali to approve given 1.13's OWNERS file contents

@saad-ali
Copy link
Member

saad-ali commented Aug 6, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@hoegaarden hoegaarden added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 8, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 8, 2019
@hoegaarden
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 48844ef into kubernetes:release-1.13 Aug 8, 2019
@davidz627 davidz627 deleted the automated-cherry-pick-of-#80923-upstream-release-1.13 branch August 8, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@matchstick matchstick Awaiting requested review from matchstick

Assignees

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@davidz627 @msau42 @hantaowang @tpepper @saad-ali @k8s-ci-robot @hoegaarden