increase timeout for maximum-startup-sequence-duration as a stopgap #80928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obability of a flake
k8s-ci-robot
added
release-note-none
|
/lgtm this works to clean up CI, will look for a longer-term fix to make this test more deterministic |
k8s-ci-robot
added
the
lgtm
|
/kind failing-test |
k8s-ci-robot
added
the
kind/failing-test
|
/area deflake |
k8s-ci-robot
added
the
area/deflake
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
TestStartupSequenceHealthzAndReadyz is flaking (#80748). This is likely due to a race condition in the bootup sequence during TestStartupServerOrDie (which takes longer than 5s to become healthy on CI) and thus never becomes healthy.
In the short term, we can increase the maximum-startup-sequence-duration value such that we give the system more time to actually become healthy before we start the test. In the longer term, @liggitt makes a few compelling arguments for adding a livez endpoint (rather than repurposing healthz the way that I did). If we opt down this path, then we can make corresponding changes to this test.
/cc @sttts