Upgrade AdmissionReview e2e test image to also support v1

[jpbetz]

Update webhook test image support v1beta1 and v1 AdmissionReview APIs
Arrange code so that internally, test admission handlers convert v1beta1 API requests to v1 before handling, but can easily handle versions via distinct code paths if needed in the future

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Special notes for your reviewer:

I am unfamiliar with how to test or publish the agnhost images.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

• KEP

/cc @liggitt @roycaihw @sttts @caesarxuchao
/sig api-machinery
/area admission-control

[jpbetz]

@BCLAU What do I need to do to test the agnhost image change in this PR?

[claudiubelu]

@BCLAU What do I need to do to test the agnhost image change in this PR?

So, first of all, since this changes webhook, we'll have to bump the image version. bump the version in test/images/agnhost/VERSION. Next, the agnhost version will also have to be bumped in test/utils/image/manifest.go.

I don't think the image promotion automation finished yet, so someone who can build and push the image to gcr.io will have to build and push it.

/cc @spiffxp

[jpbetz]

@BCLAU One more question: Is there a recipe for running e2e tests against a not-yet-published agnhost image. E.g steps to publish the image to my local docker repo and update e2e tests to use it?

[jpbetz]

@BCLAU One more question: Is there a recipe for running e2e tests against a not-yet-published agnhost image. E.g steps to publish the image to my local docker repo and update e2e tests to use it?

Nevermind, I found a way to run it locally.

[jpbetz]

@BCLAU @spiffxp This PR updates the agnhost image and contains a test/images/agnhost/VERSION bump. What are next steps to have that image pushed? Can we push it before merging this PR once it is approved or will we need to update test/utils/image/manifest.go in a separate PR?

[jpbetz]

/retest

[jpbetz]

/retest

[liggitt]

/approve
one godoc nit, lgtm otherwise

/hold
for agn image update coordination and verification of manual testing with v1 admissionreview (xref #81271 (comment))

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [liggitt]
• test/images/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

/lgtm

[liggitt]

/retest

[liggitt]

/retest
/lgtm

[jpbetz]

e2e are passing in my development environment with new image.

Steps to reproduce:

 cd test/images/agnhost
 export VERSION=<pick something>                                                                                                                                     
 export REPO=<personal repo, e.g. gcr.io/username-images>
 <edit Dockerfile, remove CROSS_BUILD_COPY, set FROM to "alpine:3.6">
 docker build -t ${REPO}/agnhost:${VERSION} .
 docker push ${REPO}/agnhost:${VERSION}

 <edit test/utils/image/manifest.go, replace e2eRegistry with "${REPO}" and version with "${VERSION}">
 <edit test/e2e/apimachinery/webhook.go, setting "AdmissionReviewVersions: []string{"v1", "v1beta1"}" everywhere>

 kubetest --build --up --test --test_args="--ginkgo.focus=AdmissionWebhook"

[liggitt]

thanks

/hold cancel

[jpbetz]

@spiffxp @BCLAU we need a build and push of the agnhost image. This PR bumped the version to 2.5.