Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error code incorrectly hidden in recordEvent #81305

Merged
merged 1 commit into from Aug 13, 2019
Merged

Error code incorrectly hidden in recordEvent #81305

merged 1 commit into from Aug 13, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Aug 12, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
In recordEvent, err is declared at the beginning of the func.

However, return value from createPatchBytesForSeries creates another error variable with same name.
The sink.Patch call stores into the second error variable which wouldn't be checked by later code.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 12, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Aug 12, 2019

/test pull-kubernetes-e2e-gce

@tedyu
Copy link
Contributor Author

tedyu commented Aug 12, 2019

/test pull-kubernetes-integration

@tedyu
Copy link
Contributor Author

tedyu commented Aug 12, 2019

/test pull-kubernetes-e2e-gce

@tedyu
Copy link
Contributor Author

tedyu commented Aug 12, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@fedebongio
Copy link
Contributor

/cc @yliaog

@yastij
Copy link
Member

yastij commented Aug 13, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedyu, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit f22b67d into kubernetes:master Aug 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 13, 2019
@haircommander haircommander mentioned this pull request Aug 20, 2019
Closed
haircommander added a commit to haircommander/kubernetes that referenced this pull request Aug 21, 2019
@haircommander
Revert "Merge pull request kubernetes#81305 from tedyu/evt-patch-err"
227030a 
This reverts commit f22b67d, reversing
changes made to 54b28ab.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander added a commit to haircommander/kubernetes that referenced this pull request Aug 22, 2019
@haircommander
Revert "Merge pull request kubernetes#81305 from tedyu/evt-patch-err"
1c03210 
This reverts commit f22b67d, reversing
changes made to 54b28ab.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij left review comments

@yliaog yliaog yliaog left review comments

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tedyu @fedebongio @yastij @k8s-ci-robot @yliaog