Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add v1.17 to the list versions that map to etcd version #81386

Merged
merged 1 commit into from
Aug 14, 2019
Merged

kubeadm: add v1.17 to the list versions that map to etcd version #81386

merged 1 commit into from
Aug 14, 2019

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Aug 13, 2019 •
edited

What this PR does / why we need it:

master now points at v1.17, thus the kubeadm upgrade tests will fail unless we add a new k8s version that maps to an etcd version.

https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-upgrade-1-15-master

[upgrade/apply] FATAL: failed to retrieve an etcd version for the target Kubernetes version: unsupported or unknown Kubernetes version(1.17.0-alpha.0.22+0910ebfeee1e28)
Error: failed to exec action kubeadm-upgrade: exit status 1

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @rosti @fabriziopandini
/kind cleanup
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot requested review from kad and rosti August 13, 2019 22:59
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 13, 2019
neolit123
neolit123 commented Aug 13, 2019
View reviewed changes
cmd/kubeadm/app/constants/constants.go
@@ -423,6 +423,7 @@ var (
14: "3.3.10",
15: "3.3.10",
16: "3.3.10",
17: "3.3.10",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version of etcd will probably (hopefully) change this release.

rosti
rosti reviewed Aug 14, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neolit123 !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2019
@rosti
Copy link
Contributor

rosti commented Aug 14, 2019

/test pull-kubernetes-verify

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d5bdb77 into kubernetes:master Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019
@fabriziopandini fabriziopandini mentioned this pull request Sep 27, 2019
Closed
7 tasks
@neolit123 neolit123 mentioned this pull request Dec 11, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosti rosti rosti left review comments

@kad kad Awaiting requested review from kad

Assignees

@rosti rosti

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neolit123 @k8s-ci-robot @rosti @fejta-bot @fabriziopandini