Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demote HPA tests from release-blocking #81537

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Demote HPA tests from release-blocking #81537

merged 1 commit into from
Aug 21, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 16, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Add a [Feature:HPA] tag to these tests so they're not picked up by the release-blocking job that focuses on [Serial] tests (but excludes [Feature:.*] tests)

They take a combined 70 minutes on average. If they really need to be in release-blocking as implemented, we should consider a separate job to focus just on this feature.

Which issue(s) this PR fixes:

Addresses part of #81491

Does this PR introduce a user-facing change?:

NONE

/priority important-soon

@spiffxp
Demote HPA tests from release-blocking
194e91b 
Add a Feature:HPA tag to these tests so they're not picked up by
the release-blocking job that focuses on [Serial] tests (but
excludes [Feature:.*] tests)

They take a combined 70 minutes on average. If they really need
to be in release-blocking as implemented, we should consider a
separate job to focus just on this feature.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 16, 2019
@spiffxp spiffxp mentioned this pull request Aug 16, 2019
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Aug 16, 2019

While I did a search to see how the [HPA] tag was used, it turns out all of the kops jobs explicitly exclude this tag. They will still end up excluding these tests by way of the [Feature:] tag.

@spiffxp
Copy link
Member Author

spiffxp commented Aug 16, 2019

/hold
for comment by @kubernetes/sig-autoscaling-pr-reviews

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Aug 16, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2019

/retest

@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2019

/assign @mwielgus
chair of sig-autoscaling

@mwielgus
Copy link
Contributor

@spiffxp I see the problem. We would rather move to a separate job than get off blocking tests completely. If possible, please keep this PR on hold while we are working on this.

cc: @josephburnett

@mwielgus mwielgus requested review from mwielgus and removed request for MaciekPytel and jszczepkowski August 19, 2019 12:14
@spiffxp
Copy link
Member Author

spiffxp commented Aug 20, 2019 •
edited

I described how to do this in #81491 (comment)

Can we accept a blip in coverage and allow this to merge so the new job can be written to focus on Feature:HPA instead of HPA?

@josephburnett
Copy link
Member

Can we accept a blip in coverage and allow this to merge so the new job can be written to focus on Feature:HPA instead of HPA?

@spiffxp sure. I'll start on the Feature:HPA job tomorrow.

@josephburnett
Copy link
Member

josephburnett commented Aug 20, 2019 •
edited

/lgtm
/approve

@spiffxp
Copy link
Member Author

spiffxp commented Aug 20, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephburnett, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josephburnett
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0dfb87d into kubernetes:master Aug 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 21, 2019
@josephburnett josephburnett mentioned this pull request Aug 21, 2019
Merged
@spiffxp spiffxp deleted the mv-hpa-tests-out-of-release-blocking branch May 29, 2020 17:28
@hakman hakman mentioned this pull request Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@josephburnett josephburnett

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spiffxp @mwielgus @josephburnett @k8s-ci-robot