Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-default container port and scoped port vars in webhook e2e tests #81541

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Use non-default container port and scoped port vars in webhook e2e tests #81541

merged 1 commit into from
Aug 21, 2019

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Aug 17, 2019 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Conformance tests for CRD GA and Admission Webhooks GA should exercise the use of a non-default webhook port.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @liggitt @roycaihw @sttts @caesarxuchao
/sig api-machinery
/area custom-resources

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 17, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/custom-resources size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 17, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt added this to Required for GA, in progress in Custom Resource Definitions Aug 17, 2019
@liggitt liggitt added this to Required for GA, in progress in Admission Webhooks Aug 18, 2019
@jpbetz jpbetz force-pushed the alternate-port branch 2 times, most recently from b1b24fa to f9189cb Compare August 20, 2019 17:04
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 20, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 20, 2019

Rebased on master, merged with v1 admission changes, e2e tests passed locally.

@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 20, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 20, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 20, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 20, 2019

I've rewritten the PR to just swap the container port with a non-default one which is much simpler. It's still more than 3 lines because I removed the global port variable and replaced it with a context scoped one which required threading a param through the stack, which is conceptually trivial but took quite a few lines to do.

@liggitt
Copy link
Member

liggitt commented Aug 20, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@jpbetz jpbetz changed the title Add e2e test exercising alternative port in webhook service references Use non-default container port and scoped port vars in webhook e2e tests Aug 20, 2019
@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 20, 2019

/test pull-kubernetes-bazel-test
Build output shows that the tests passed (https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/81541/pull-kubernetes-bazel-test/1163907284804308992) retrying

@k8s-ci-robot k8s-ci-robot merged commit fd724db into kubernetes:master Aug 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 21, 2019
@liggitt liggitt moved this from Required for GA, in progress to Complete in Admission Webhooks Aug 21, 2019
@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@roycaihw roycaihw Awaiting requested review from roycaihw

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/admission-control area/apiserver area/custom-resources area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Admission Webhooks
Complete
Custom Resource Definitions
Complete
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpbetz @fejta-bot @liggitt @k8s-ci-robot