Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typecheck cleanup #81547

Merged
merged 2 commits into from Aug 17, 2019
Merged

typecheck cleanup #81547

merged 2 commits into from Aug 17, 2019

Conversation

BenTheElder
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Removes some unnecessary ignore logic from typecheck and replaces @rmmh as a reviewer with myself (and for the go-srcimporter copy that goes with it). Ryan is not active on the project currently, and I'd like to help review these packages.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig testing

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2019
BenTheElder
BenTheElder commented Aug 17, 2019
View reviewed changes
test/typecheck/main.go
if strings.Contains(e.Msg, "GetOpenAPIDefinitions") {
// TODO(rmmh): figure out why this happens.
// cmd/kube-apiserver/app/server.go:392:70
// test/integration/framework/master_utils.go:131:84
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code (test/integration/framework/master_utils.go) changed and doesn't need this anymore AFAICT. We've also never changed this, so I'm just removing the entirety of this logic.

BenTheElder
BenTheElder commented Aug 17, 2019
View reviewed changes
test/typecheck/OWNERS
- cblecker
- rmmh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I did NOT change approvers (below) in either file, though I am an approver of test/ and third_party (EDIT: no, third_party is not covered by dep-approvers) anyhow so perhaps that would make more sense.
When I authored this I was thinking more about review ... @cblecker

@BenTheElder
Copy link
Member Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 17, 2019
@BenTheElder
Copy link
Member Author

/retest

2 similar comments
@BenTheElder
Copy link
Member Author

/retest

@spiffxp
Copy link
Member

spiffxp commented Aug 17, 2019

/retest

@spiffxp
Copy link
Member

spiffxp commented Aug 17, 2019

/lgtm
/approve
the test/ changes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2019
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit f12a40d into kubernetes:master Aug 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 17, 2019
@BenTheElder BenTheElder deleted the typecheck-cleanup branch August 29, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@rmmh rmmh Awaiting requested review from rmmh

Assignees

@spiffxp spiffxp

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenTheElder @spiffxp @cblecker @k8s-ci-robot