Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb context timeout to admission webhooks #81602

Merged
merged 3 commits into from
Aug 21, 2019
Merged

Plumb context timeout to admission webhooks #81602

merged 3 commits into from
Aug 21, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 19, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
Plumbs context to admission webhooks, uses lesser of context deadline or webhook-specific timeout when calling webhooks.

Which issue(s) this PR fixes:
Fixes #78783

Does this PR introduce a user-facing change?:

NONE

/sig api-machinery
/cc @jpbetz @sttts

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 19, 2019
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 19, 2019
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 19, 2019
@liggitt
Copy link
Member Author

liggitt commented Aug 19, 2019 •
edited

/priority important-soon
/milestone v1.16
/area admission-control

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 19, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/admission-control and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 19, 2019
@liggitt liggitt mentioned this pull request Aug 19, 2019
Closed
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/auth Categorizes an issue or PR as relevant to SIG Auth. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 19, 2019
@liggitt liggitt added this to Required for GA, in progress in Admission Webhooks Aug 19, 2019
@liggitt liggitt force-pushed the admission-context branch 3 times, most recently from d78fa70 to 0172f72 Compare August 19, 2019 19:25
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2019
@liggitt liggitt changed the title WIP - Plumb context to admission webhooks Plumb context timeout to admission webhooks Aug 20, 2019
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 20, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 20, 2019
@liggitt
Copy link
Member Author

liggitt commented Aug 20, 2019

comments addressed, integration test added

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 20, 2019
jpbetz
jpbetz reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise lgtm

staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/validating/dispatcher.go Show resolved Hide resolved
@jpbetz
Copy link
Contributor

jpbetz commented Aug 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit bad4d0e into kubernetes:master Aug 21, 2019
@liggitt liggitt moved this from Required for GA, in progress to Complete in Admission Webhooks Aug 21, 2019
@liggitt liggitt deleted the admission-context branch August 21, 2019 20:43
@liggitt liggitt mentioned this pull request Sep 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@sttts sttts Awaiting requested review from sttts

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/admission-control area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Admission Webhooks
Complete
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

kube-apiserver goruntine leak when admission or call webhooks
3 participants
@liggitt @k8s-ci-robot @jpbetz