-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumb context timeout to admission webhooks #81602
Conversation
/priority important-soon |
d78fa70
to
0172f72
Compare
staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/mutating/dispatcher.go
Show resolved
Hide resolved
0172f72
to
f6ec817
Compare
comments addressed, integration test added |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise lgtm
staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/validating/dispatcher.go
Show resolved
Hide resolved
f6ec817
to
c63284b
Compare
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Plumbs context to admission webhooks, uses lesser of context deadline or webhook-specific timeout when calling webhooks.
Which issue(s) this PR fixes:
Fixes #78783
Does this PR introduce a user-facing change?:
/sig api-machinery
/cc @jpbetz @sttts