moving ShuffleStrings to pkg/proxy

[yastij]

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What type of PR is this?

/kind cleanup
/sig api-machinery

What this PR does / why we need it: this moves the slice package to apimachinery repository in order to be able to move some controllers out k/k

Which issue(s) this PR fixes: part of #81172

Special notes for your reviewer:

/assign @liggitt @dims

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[yastij]

/priority important-soon

[neolit123]

/assign @andrewsykim
as per #81172

@yastij
there seem to be BUILD related problems in the CI logs, would ./hack/update-bazel.sh solve that?

+1 on the change.

[andrewsykim]

pkg/util/slice seems mostly specific to strings, wondering if it makes more sense to add it to k8s.io/utils/strings?

[yastij]

@andrewsykim - this would pull util/rand's apimachinery package into k/utils

[andrewsykim]

I think k8s.io/apimachinery/pkg/util/rand could also belong in k8s.io/utils but will let someone from API Machinery comment on that one.

[yastij]

cc @kubernetes/sig-api-machinery-pr-reviews

[liggitt]

the ShuffleStrings method is only used by pkg/proxy/.... I'd probably move that one out to the proxy package, drop the utilrand dependency, and move the rest to k/utils with no non-stdlib dependencies

[yastij]

sgtm

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@yastij: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-storage-slow	57686acf7e06ad97a59ae89694f81a80e2183511	link	/test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-gce-csi-serial	57686acf7e06ad97a59ae89694f81a80e2183511	link	/test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[yastij]

/retest

[thockin]

I'm not convinced that any of the logic here rises to the level of a new pkg in k/utils. It's all just trivial stuff.

[liggitt]

I'm not convinced that any of the logic here rises to the level of a new pkg in k/utils. It's all just trivial stuff.

that's fair, too.