-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix staticcheck failures in test/utils/...
#81904
Fix staticcheck failures in test/utils/...
#81904
Conversation
/assign @ixdy |
/approve |
The `err` return value was being overwritten in an unintended way, which means the function may not return the proper error value. This diff ensures it does.
856d02b
to
42f8596
Compare
/assign @liggitt @tallclair Resolved the merge conflict. Mind taking a look? Thanks :) |
/priority backlog |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mattjmcnaughton, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
err
return value was being overwritten in an unintended way, whichmeans the function may not return the proper error value. This diff
ensures it does.
Which issue(s) this PR fixes:
ref #81657
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: