Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use log functions of core framework on test/e2e/scheduling #81982

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Use log functions of core framework on test/e2e/scheduling #81982

merged 1 commit into from
Sep 11, 2019

Conversation

s-ito-ts
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This makes test/e2e/scheduling/* to use log functions of core framework.

Which issue(s) this PR fixes:
Ref: #81427

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 27, 2019
hex108
hex108 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@hex108 hex108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @s-ito-ts

/lgtm
/assign @Huang-Wei

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2019
@hex108
Copy link
Contributor

hex108 commented Aug 27, 2019

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Aug 27, 2019
@s-ito-ts
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ipv6

Huang-Wei
Huang-Wei reviewed Aug 27, 2019
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, s-ito-ts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@s-ito-ts
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ipv6

@hex108
Copy link
Contributor

hex108 commented Aug 28, 2019

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 28, 2019
@pohly
Copy link
Contributor

pohly commented Aug 29, 2019

/test pull-kubernetes-bazel-test

@liggitt
Copy link
Member

liggitt commented Aug 29, 2019

/test pull-kubernetes-bazel-build

@pohly
Copy link
Contributor

pohly commented Aug 29, 2019 •
edited

Duh, I triggered the wrong test. Thanks @liggitt!

FWIW, the problem is a build failure in:
https://prow.k8s.io/?repo=kubernetes%2Fkubernetes&type=batch&pull=master%2C81947%2C81973%2C81982%2C81990%2C81993

I propose we hold this less important PR ("cleanup", no priority set) until the merge pool is smaller.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@pohly
Copy link
Contributor

pohly commented Aug 29, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@Huang-Wei
Copy link
Member

@s-ito-ts you may need to take a look at the CI failure.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@oomichi
Copy link
Member

oomichi commented Aug 29, 2019

@s-ito-ts you may need to take a look at the CI failure.

As @Huang-Wei said, this test failure is due to this change itself.
According to https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/81982/pull-kubernetes-bazel-build/1167193535053565953/build-log.txt
the error message is

/b/f/w/test/e2e/scheduling/predicates.go:101:4: undefined: e2elog

So e2elog has been added at predicates.go:101 after proposing this PR and the CI job is failed now.
We need to update this PR.
(pull-kubernetes-bazel-build tends to be stable, not flake. If that is failed continuously, it is better to check the log from the above Details)

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@oomichi
Copy link
Member

oomichi commented Aug 29, 2019

/cc @oomichi

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2019
@s-ito-ts
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ipv6

@wgliang
Copy link
Contributor

wgliang commented Aug 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2019
@oomichi
Copy link
Member

oomichi commented Aug 30, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit e60fd89 into kubernetes:master Sep 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@hex108 hex108 hex108 approved these changes

@wgliang wgliang Awaiting requested review from wgliang

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@hex108 hex108

@Huang-Wei Huang-Wei

@wgliang wgliang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@s-ito-ts @hex108 @k8s-ci-robot @fejta-bot @pohly @liggitt @Huang-Wei @oomichi @wgliang