Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types in versioned scheduler api are not sized #82138

Closed
alculquicondor opened this issue Aug 29, 2019 · 4 comments · Fixed by #82283
Closed

Types in versioned scheduler api are not sized #82138

alculquicondor opened this issue Aug 29, 2019 · 4 comments · Fixed by #82283
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@alculquicondor
Copy link
Member

/sig scheduling
/sig api-machinery

#53850 changed a some types to sized integers in https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/api/types.go but not in https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/api/v1/types.go

This leaves to problems when encoding and decoding between types. For example, this is blocking #81911

We should migrate all types to sized integers in both files.

@alculquicondor alculquicondor added the kind/bug Categorizes issue or PR as related to a bug. label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 29, 2019
@alculquicondor
Copy link
Member Author

cc @ahg-g @bsalamat @ahmad-diaa

@ahmad-diaa
Copy link
Contributor

I can work on this as I have been involved with the blocked PR
/assign

@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 5, 2019
@alculquicondor
Copy link
Member Author

@fedebongio this issue comes as a consequence of #53850 having left overs. It looks like this PR didn't have any sig labels. In any case, please confirm if api-machinery doesn't need to be involved in this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants