fix BusyBox sed

[tipok]

BusyBox sed works the same way as GNU sed

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Code completion for zsh under alpine is not working currently because BusyBox sed is not identified as a GNU sed.
This leads to
LWORD='[[:<:]]'
RWORD='[[:>:]]'
which is not working in BusyBox sed

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @tipok!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tipok. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tipok]

/assign @janetkuo @rosti

[neolit123]

thanks for the PR @tipok ,
does kubeadm even work on Alpine?
it only supports systemd ATM and AFAIK Alpine needs OpenRC.

in any case we are currently in code freeze, and this can merge after the 10th of Sept.

[tipok]

@neolit123 thank you.
Actually i haven't tested kubeadm.
I just aligned two of the snippets to stay the same. Not sure if running kubeadm on a machine with BusyBox' sed is a valid use case. Let me know if i should remove the change in kubeadm.

[neolit123]

@tipok
possible better to omit the kubeadm change for now.
if users discover the bug (possibly in the future once we support OpenRC) we can look into fixing the non-GNU sed problems.

[tipok]

@neolit123
changed the PR. Thank you

[neolit123]

/remove-area kubeadm
/ok-to-test
/priority backlog

thanks.
if you are not getting any review from the kubectl maintainers, try asking in the #sig-cli channel on slack.

[tipok]

/retest

[tipok]

i've merged the master into my fork. I'm not sure if this can be merged now. The same changes are merged in the helm release.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[tipok]

@neolit123 and @dixudx after some merges into the master i had to merge the master into my fork so it's not conflicting. because of that labels were removed.

I would be very happy if you could recheck the PR and maybe merge it into the master.

Thank you.

[neolit123]

hi,
please squash the commits locally and force push to have a single one.

do-not-merge/contains-merge-commits

the bots will not allow adding merge commits.

i can then re-apply LGTM for you, but you still need to find an approver.
maybe pinging someone from https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS on k8s slack.

/remove-lifecycle stale

[tipok]

@neolit123 thank you for the clarification.

[neolit123]

/lgtm
/retest

type /retest on non-related CI failures.

[tipok]

/assign @janetkuo

[janetkuo]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, tipok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [janetkuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tipok]

/test pull-kubernetes-e2e-kind