Don't require any resources in race test #82245
Conversation
The race test is interested only if all volumes are mounted and pod is started, it does not need any special CPU. It de-flakes the test when running on a tight node.
k8s-ci-robot
added
release-note-none
jsafrane
force-pushed
the
use-pause-for-race
branch
from
dbc6fcf
to
1e602ca
Compare
k8s-ci-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| }, | ||
| }, | ||
| Name: "test-container", | ||
| Image: imageutils.GetE2EImage(imageutils.Pause), |
There was a problem hiding this comment.
My only q would be whether k8s has special behavior around the pause image, that would somehow make this a non-representative test? My guess is that this should work fine, but just wanted to double check :)
There was a problem hiding this comment.
I think there should be no difference in behaviour, just a nicer way of sleep'ing :)
| }, | ||
| }, | ||
| Name: "test-container", | ||
| Image: imageutils.GetE2EImage(imageutils.Pause), |
There was a problem hiding this comment.
I think there should be no difference in behaviour, just a nicer way of sleep'ing :)
k8s-ci-robot
added
the
lgtm
The race test is interested only if all volumes are mounted and pod is started, it does not need any special CPU. Also use
pausepod to save CPU / image pull.It de-flakes the test when running on a tight node (which happened in a downstream test job).
/kind cleanup
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig node
/sig storage
@bertinatto, PTAL?