New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessarily Exported MaxInt in scheduler api types #82306
Labels
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
Comments
k8s-ci-robot
added
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
and removed
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
labels
Sep 4, 2019
The problem is that it is part of a v1 API :( |
Ok, it turns out they are not actually considered part of the API, and so we can remove them: #82283 (comment) |
@ahg-g Should I open a PR to address removing those const values from |
Yes, we can remove those in a followup PR to the one handling sized values. |
Yes, this was the plan. |
@ahmad-diaa remember to remove |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MaxInt const is exported in scheduler api
kubernetes/pkg/scheduler/api/types.go
Line 31 in 6cb788c
plugins_test.go
.#81263 (comment) discussed that the common practice is to have API constants in
defaults.go
/sig scheduling
The text was updated successfully, but these errors were encountered: