Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup staticcheck for package cache #82325

Merged
merged 1 commit into from Sep 17, 2019
Merged

Cleanup staticcheck for package cache #82325

merged 1 commit into from Sep 17, 2019

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Cleanup issues identified by staticcheck in #81189

Errors from staticcheck:

vendor/k8s.io/client-go/tools/cache/delta_fifo.go:542:21: func (*DeltaFIFO).syncKey is unused (U1000)
vendor/k8s.io/client-go/tools/cache/reflector.go:49:2: field metrics is unused (U1000)
vendor/k8s.io/client-go/tools/cache/reflector.go:133:2: var errorResyncRequested is unused (U1000)
vendor/k8s.io/client-go/tools/cache/reflector_metrics.go:50:6: type reflectorMetrics is unused (U1000)

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2019
@yue9944882
Copy link
Member

cc @deads2k (backtracking to the author)

@RainbowMango
Copy link
Member Author

/retest

@fedebongio
Copy link
Contributor

/assign @caesarxuchao

caesarxuchao
caesarxuchao reviewed Sep 5, 2019
View reviewed changes
staging/src/k8s.io/client-go/tools/cache/reflector.go
@@ -45,8 +45,6 @@ import (
type Reflector struct {
// name identifies this reflector. By default it will be a file:line if possible.
name string
// metrics tracks basic metric information about the reflector
metrics *reflectorMetrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting the metrics, we probably should fix the metrics, see workqueue metrics as an example.

@logicalhan IIRC there was a plan to overhaul the metrics in k8s. I don't know if that plan will affect the fix in this package. Could you advise? Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually these metrics are already deleted. #74636, I believe I missed these references in my cleanup. My apologies.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is staticcheck works.
Maybe we will never miss any cleanup anymore after this pr.

@caesarxuchao
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@RainbowMango
Copy link
Member Author

/assign @SataQiu
For hack.

SataQiu
SataQiu reviewed Sep 17, 2019
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks @RainbowMango

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, RainbowMango, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 41b3e60 into kubernetes:master Sep 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 17, 2019
@RainbowMango RainbowMango deleted the pr_cleanupup_staticcheck_for_client_cache branch September 17, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan left review comments

@caesarxuchao caesarxuchao caesarxuchao left review comments

@SataQiu SataQiu SataQiu left review comments

@ixdy ixdy Awaiting requested review from ixdy

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@caesarxuchao caesarxuchao

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@RainbowMango @yue9944882 @fedebongio @caesarxuchao @k8s-ci-robot @logicalhan @SataQiu