don't start the cloud node controller if cloudprovider.Instances is not supported #82329

m3ngyang · 2019-09-04T11:37:10Z

What type of PR is this?
/kind bug
/kind cleanup

What this PR does / why we need it:
There are some tiny bugs in the cloud node controller:

node_controller doesn't check cloud, kubeClient before using them.
node_lifecycle_controller checks kubeClient after using it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

k8s-ci-robot · 2019-09-04T11:37:18Z

Hi @m3ngyang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

m3ngyang · 2019-09-05T02:00:26Z

/assign @andrewsykim
PTAL~

andrewsykim · 2019-09-05T17:00:55Z

cmd/cloud-controller-manager/app/core.go

+	)
+	if err != nil {
+		klog.Warningf("failed to start cloud node controller: %s", err)
+		return nil, false, err


To be consistent with the other controllers here, I think this should be

return nil, false, nil

Otherwise the entire process exits on err.

Please make it consistent with other controllers as this will be important for future work making the controller initialization generic.

andrewsykim

minor comment, lgtm otherwise :)

fedebongio · 2019-09-05T20:20:30Z

/assign @cheftako

cheftako · 2019-09-05T23:45:20Z

pkg/controller/cloud/node_controller.go

+	}
+
+	if cloud == nil {
+		return nil, errors.New("no cloud provider provided")


Something has gone very wrong to get here. Failure to init the cloud provider in the CCM is a fatal error...

Yes, cloud has been checked before passing to the constructor, and kubeClient is created by ctx.ClientBuilder.ClientOrDie("node-controller")

kubernetes/pkg/controller/client_builder.go

Lines 81 to 87 in 3a50184

func (b SimpleControllerClientBuilder) ClientOrDie(name string) clientset.Interface {

client, err := b.Client(name)

if err != nil {

klog.Fatal(err)

}

return client

}

so, we don't need to check cloud and kubeClient in the controller initializers.

Agree we probably don't need those checks but probably doesn't hurt to keep them

emmm, I think it could be viewed as a cleanup for codes. There are many controllers consist of cloud and kubeClient, we don't need to check them every time.

Fine with me :)

andrewsykim · 2019-09-06T15:18:26Z

/ok-to-test

andrewsykim · 2019-09-06T15:27:23Z

pkg/controller/cloud/node_controller.go


 	eventBroadcaster := record.NewBroadcaster()
 	recorder := eventBroadcaster.NewRecorder(scheme.Scheme, v1.EventSource{Component: "cloud-node-controller"})
 	eventBroadcaster.StartLogging(klog.Infof)
-	if kubeClient != nil {


Let's add a cloud.Instances() check similar to NewCloudNodeLifecycleController?

It sounds good.

cloud.Instances() has been added.

andrewsykim · 2019-09-06T17:04:54Z

/retitle don't start the cloud node controller if cloudprovider.Instances is not supported

andrewsykim · 2019-09-06T17:05:34Z

/approve
/lgtm

k8s-ci-robot · 2019-09-06T17:06:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, m3ngyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/cloud-controller-manager/OWNERS~~ [andrewsykim]
~~pkg/controller/cloud/OWNERS~~ [andrewsykim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andrewsykim · 2019-09-06T17:07:40Z

/priority important-longterm

m3ngyang · 2019-09-06T17:47:46Z

/test pull-kubernetes-integration

fejta-bot · 2019-09-06T20:51:38Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2019-09-07T00:03:47Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

m3ngyang · 2019-09-07T02:56:02Z

I made a mistake about cloud check in NewCloudNodeLifecycleController. This constructor will be called by cloud-controller-manager and kube-controller-manager, the former checks cloud before passing it to the New function, but the latter does not. So we'd better not change pkg/controller/cloud/node_lifecycle_controller.go currently. @andrewsykim

andrewsykim · 2019-09-09T12:49:03Z

/lgtm

m3ngyang · 2019-09-09T13:41:32Z

Would this pr be included in 1.16? @andrewsykim

andrewsykim · 2019-09-09T15:29:19Z

I think this is more a sanity check then it is a bug so I don't think we need to push this to v1.16, what do you think?

m3ngyang · 2019-09-09T16:04:49Z

It makes sense. This pr can be merged after releasing 1.16.

cheftako · 2019-09-09T17:53:32Z

/lgtm

k8s-ci-robot requested review from sttts and thockin September 4, 2019 11:37

k8s-ci-robot assigned andrewsykim Sep 5, 2019

andrewsykim reviewed Sep 5, 2019

View reviewed changes

k8s-ci-robot assigned cheftako Sep 5, 2019

cheftako reviewed Sep 5, 2019

View reviewed changes

m3ngyang force-pushed the node-ctrl-check branch from 5086981 to c287ca1 Compare September 6, 2019 03:03

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2019

andrewsykim reviewed Sep 6, 2019

View reviewed changes

m3ngyang force-pushed the node-ctrl-check branch from c287ca1 to a480f03 Compare September 6, 2019 16:07

k8s-ci-robot changed the title ~~param check for cloud node controller~~ don't start the cloud node controller if cloudprovider.Instances is not supported Sep 6, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019

k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 6, 2019

init check for cloud node controller

b463851

m3ngyang force-pushed the node-ctrl-check branch from a480f03 to b463851 Compare September 7, 2019 02:47

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2019

k8s-ci-robot merged commit 61b30b0 into kubernetes:master Sep 11, 2019

k8s-ci-robot added this to the v1.17 milestone Sep 11, 2019

m3ngyang deleted the node-ctrl-check branch September 12, 2019 00:04

m3ngyang mentioned this pull request Oct 10, 2019

REQUEST: New membership for m3ngyang kubernetes/org#1285

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't start the cloud node controller if cloudprovider.Instances is not supported #82329

don't start the cloud node controller if cloudprovider.Instances is not supported #82329

m3ngyang commented Sep 4, 2019

k8s-ci-robot commented Sep 4, 2019

m3ngyang commented Sep 5, 2019

andrewsykim Sep 5, 2019

cheftako Sep 5, 2019

m3ngyang Sep 6, 2019

andrewsykim left a comment

fedebongio commented Sep 5, 2019

cheftako Sep 5, 2019

m3ngyang Sep 6, 2019

andrewsykim Sep 6, 2019

m3ngyang Sep 6, 2019

andrewsykim Sep 6, 2019

andrewsykim commented Sep 6, 2019

andrewsykim Sep 6, 2019

m3ngyang Sep 6, 2019

m3ngyang Sep 6, 2019

andrewsykim commented Sep 6, 2019

andrewsykim commented Sep 6, 2019

k8s-ci-robot commented Sep 6, 2019

andrewsykim commented Sep 6, 2019

m3ngyang commented Sep 6, 2019

fejta-bot commented Sep 6, 2019

fejta-bot commented Sep 7, 2019

m3ngyang commented Sep 7, 2019

andrewsykim commented Sep 9, 2019

m3ngyang commented Sep 9, 2019

andrewsykim commented Sep 9, 2019

m3ngyang commented Sep 9, 2019

cheftako commented Sep 9, 2019

	func (b SimpleControllerClientBuilder) ClientOrDie(name string) clientset.Interface {
	client, err := b.Client(name)
	if err != nil {
	klog.Fatal(err)
	}
	return client
	}

don't start the cloud node controller if cloudprovider.Instances is not supported #82329

don't start the cloud node controller if cloudprovider.Instances is not supported #82329

Conversation

m3ngyang commented Sep 4, 2019

k8s-ci-robot commented Sep 4, 2019

m3ngyang commented Sep 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewsykim left a comment

Choose a reason for hiding this comment

fedebongio commented Sep 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewsykim commented Sep 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewsykim commented Sep 6, 2019

andrewsykim commented Sep 6, 2019

k8s-ci-robot commented Sep 6, 2019

andrewsykim commented Sep 6, 2019

m3ngyang commented Sep 6, 2019

fejta-bot commented Sep 6, 2019

fejta-bot commented Sep 7, 2019

m3ngyang commented Sep 7, 2019

andrewsykim commented Sep 9, 2019

m3ngyang commented Sep 9, 2019

andrewsykim commented Sep 9, 2019

m3ngyang commented Sep 9, 2019

cheftako commented Sep 9, 2019