Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alejandrox1 as test/e2e/framework reviewer #82433

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Added alejandrox1 as test/e2e/framework reviewer #82433

merged 1 commit into from
Sep 12, 2019

Conversation

alejandrox1
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
I have been working with the testing-commons subproject reviewing and drafting PRs and I would like to continue doing more of it 馃槂

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/priority backlog
/assign @timothysc @andrewsykim @oomichi

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2019
@alejandrox1
Copy link
Contributor Author

/sig testing
/area e2e-test-framework

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2019
@andrewsykim
Copy link
Member

/retest
/approve
/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2019
oomichi
oomichi reviewed Sep 6, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @alejandrox1
big +1

/lgtm

odinuge
odinuge approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me! Thanks for the good work!!
/lgtm

neolit123
neolit123 reviewed Sep 6, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
welcome @alejandrox1

@BenTheElder
Copy link
Member

+1 :-)

timothysc
timothysc approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, andrewsykim, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timothysc timothysc added this to the v1.17 milestone Sep 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 118ae22 into kubernetes:master Sep 12, 2019
@alejandrox1 alejandrox1 deleted the patch-1 branch September 12, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@oomichi oomichi oomichi left review comments

@timothysc timothysc timothysc approved these changes

@odinuge odinuge odinuge approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@timothysc timothysc

@neolit123 neolit123

@oomichi oomichi

@odinuge odinuge

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@alejandrox1 @andrewsykim @BenTheElder @k8s-ci-robot @timothysc @neolit123 @oomichi @odinuge