-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comment for syncHandler #82455
Conversation
``` // If the Deployment is not controlled by this Foo resource, we should log // a warning to the event recorder and return error msg ``` For a clearer understanding of the comment.
Welcome @AdheipSingh! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @AdheipSingh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @munnerz |
/ok-to-test |
/lgtm |
/retest |
@jennybuckley why is the test failing ? |
/retest |
/kind cleanup @munnerz 👋 ping for approval |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AdheipSingh, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority backlog |
/retest
…On Wed, Oct 16, 2019 at 10:28 PM Kubernetes Prow Robot < ***@***.***> wrote:
@AdheipSingh <https://github.com/AdheipSingh>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce db303bc
<db303bc>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/82455/pull-kubernetes-e2e-gce/1184510282584559617/> /test
pull-kubernetes-e2e-gce
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=82455>. Your
PR dashboard <https://gubernator.k8s.io/pr/AdheipSingh>. Please help us
cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#82455?email_source=notifications&email_token=AD24BUE5OJU6PSZ7MBEDOK3QO5B3VA5CNFSM4IUQDCH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNGLGY#issuecomment-542795163>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUCES23NHVUQLK3LL6TQO5B3VANCNFSM4IUQDCHQ>
.
|
/retest
…On Thu, Oct 17, 2019 at 12:16 AM Kubernetes Prow Robot < ***@***.***> wrote:
@AdheipSingh <https://github.com/AdheipSingh>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce db303bc
<db303bc>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/82455/pull-kubernetes-e2e-gce/1184514945711083520/> /test
pull-kubernetes-e2e-gce
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=82455>. Your
PR dashboard <https://gubernator.k8s.io/pr/AdheipSingh>. Please help us
cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#82455?email_source=notifications&email_token=AD24BUAWGP6EKAPQNJ4BIT3QO5OQRA5CNFSM4IUQDCH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNQUEQ#issuecomment-542837266>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUCCMMYWXVHTDOVJZVTQO5OQRANCNFSM4IUQDCHQ>
.
|
/retest
…On Thu, 17 Oct 2019 at 1:45 AM, Kubernetes Prow Robot < ***@***.***> wrote:
@AdheipSingh <https://github.com/AdheipSingh>: The following test *failed*,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce db303bc
<db303bc>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/82455/pull-kubernetes-e2e-gce/1184542122754183168/> /test
pull-kubernetes-e2e-gce
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=82455>. Your
PR dashboard <https://gubernator.k8s.io/pr/AdheipSingh>. Please help us
cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#82455?email_source=notifications&email_token=AD24BUDRMJOVIRHY4EG6EYLQO5Y6HA5CNFSM4IUQDCH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNZEKY#issuecomment-542872107>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUBMEVL5ABR7KVUQGX3QO5Y6HANCNFSM4IUQDCHQ>
.
|
/retest Review the full test history for this PR. Silence the bot with an |
For a clearer understanding of the comment.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: