Add apigroup to the data source of pvc description #82464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
cwdsuzhou
force-pushed
the
Sep/add_apigroup_to_datasource
branch
from
2a0ef5e
to
9cedf5d
Compare
msau42
reviewed
Sep 9, 2019
| @@ -1549,6 +1549,9 @@ func describePersistentVolumeClaim(pvc *corev1.PersistentVolumeClaim, events *co | |||
| } | |||
| if pvc.Spec.DataSource != nil { | |||
| w.Write(LEVEL_0, "DataSource:\n") | |||
| if pvc.Spec.DataSource.APIGroup != nil { | |||
| w.Write(LEVEL_1, "APIGroup:\t%v\n", *pvc.Spec.DataSource.APIGroup) | |||
| } | |||
| w.Write(LEVEL_1, "Name:\t%v\n", pvc.Spec.DataSource.Name) | |||
| w.Write(LEVEL_1, "Kind:\t%v\n", pvc.Spec.DataSource.Kind) | |||
There was a problem hiding this comment.
That's better, thanks!
done
cwdsuzhou
force-pushed
the
Sep/add_apigroup_to_datasource
branch
from
9cedf5d
to
a88812f
Compare
|
/retest |
k8s-ci-robot
added
the
lgtm
|
/priority important-longterm |
k8s-ci-robot
added
priority/important-longterm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cwdsuzhou, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
msau42
reviewed
Sep 10, 2019
| @@ -1551,6 +1551,9 @@ func describePersistentVolumeClaim(pvc *corev1.PersistentVolumeClaim, events *co | |||
| w.Write(LEVEL_0, "DataSource:\n") | |||
| w.Write(LEVEL_1, "Name:\t%v\n", pvc.Spec.DataSource.Name) | |||
| w.Write(LEVEL_1, "Kind:\t%v\n", pvc.Spec.DataSource.Kind) | |||
| if pvc.Spec.DataSource.APIGroup != nil { | |||
There was a problem hiding this comment.
Should the order be large->small, or small->large? ie
- apigroup, kind, name
- name, kind, apigroup
It looks like other places do the first, so we should try to be consistent.
There was a problem hiding this comment.
I'd expect group, kind, name
I also expect this. wdyt? @msau42
k8s-ci-robot
removed
the
lgtm
cwdsuzhou
force-pushed
the
Sep/add_apigroup_to_datasource
branch
from
a88812f
to
9157df4
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest Review the full test history for this PR. Silence the bot with an |
wking
pushed a commit
to wking/kubernetes
that referenced
this pull request
Jul 21, 2020
…o_datasource Add apigroup to the data source of pvc description Kubernetes-commit: bd62a85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind bug
What this PR does / why we need it:
We missed it in #76463
Which issue(s) this PR fixes:
Fixes #82463
Special notes for your reviewer:
/cc @msau42
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: