Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -x to du commands to not traverse other file systems #82474

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

cwdsuzhou
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

See #71293
Since we can not get feedback from @ehmm, I would like open this PR to fix it

Which issue(s) this PR fixes:

Fixes #71012
Special notes for your reviewer:

/cc @jingxu97 @msau42

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

@cwdsuzhou: The label(s) kind/ cannot be appled. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

See #71293
Since we can not get feedback from @ehmm, I would like open this PR to fix it

Which issue(s) this PR fixes:

Fixes #71012
Special notes for your reviewer:

/cc @jingxu97 @msau42

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 9, 2019
@cwdsuzhou
Copy link
Member Author

/assign @saad-ali

@msau42
Copy link
Member

msau42 commented Sep 9, 2019

/assign @jingxu97 @dashpole
#71293 tried to fix it by changing the cadvisor call, whereas this PR is fixing it in the VolumeMetrics interface, which gets output as pod volume usage under summary metrics. Can you clarify where the cadvisor usage metric is used and if we should look into fixing that too?

@dashpole
Copy link
Contributor

/lgtm
The cadvisor change was for collection of metrics for the container writable layer. However, we had already switched to a golang implementation to replace du and find. We should probably transition the volume metrics collection to use the golang implementation, but can do this in the meantime.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@msau42
Copy link
Member

msau42 commented Sep 10, 2019

Thanks for the explanation! lgtm

@cwdsuzhou can you update your PR title to reflect that it's adding "-x" option, not "-s"

@msau42
Copy link
Member

msau42 commented Sep 10, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 10, 2019
@cwdsuzhou cwdsuzhou changed the title Add -s to du commands to not traverse other file systems Add -x to du commands to not traverse other file systems Sep 11, 2019
@k8s-ci-robot
Copy link
Contributor

@cwdsuzhou: The label(s) kind/ cannot be appled. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

See #71293
Since we can not get feedback from @ehmm, I would like open this PR to fix it

Which issue(s) this PR fixes:

Fixes #71012
Special notes for your reviewer:

/cc @jingxu97 @msau42

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42
Copy link
Member

msau42 commented Sep 11, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwdsuzhou, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@cwdsuzhou
Copy link
Member Author

@msau42 should we cherry pick this PR to other release versions?

@k8s-ci-robot k8s-ci-robot merged commit d1c6898 into kubernetes:master Sep 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiskUsage measurement doesn't ignore sub-mounts
7 participants