Skip e2e tests that require node independent volume for the drivers that don't support node independent volumes #82678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
mucahitkurt
changed the title
msau42
reviewed
Sep 12, 2019
| CapControllerExpansion Capability = "controllerExpansion" // support volume expansion for controller | ||
| CapNodeExpansion Capability = "nodeExpansion" // support volume expansion for node | ||
| CapVolumeLimits Capability = "volumeLimits" // support volume limits (can be *very* slow) | ||
| CapNodeIndependentVolume Capability = "nodeIndependentVolume" // support node independent volume (unlike hostpath) |
There was a problem hiding this comment.
How about calling it "singleNodeVolume"? Then multi-node tests are enabled by default.
There was a problem hiding this comment.
it would be better, I thought that kind of thing to not change all drivers but couldn't find a good name to feel it's ability not disability :)
…ndent volume for the drivers that does not support node independent volumes, like hostpath Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
mucahitkurt
force-pushed
the
skip-multi-node-vol-availability-tests-for-hostpath
branch
from
b8a4b4f
to
f0aa13c
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, mucahitkurt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mucahitkurt
deleted the
skip-multi-node-vol-availability-tests-for-hostpath
branch
pohly
reviewed
Dec 3, 2019
| @@ -155,7 +155,8 @@ const ( | |||
| CapRWX Capability = "RWX" // support ReadWriteMany access modes | |||
| CapControllerExpansion Capability = "controllerExpansion" // support volume expansion for controller | |||
| CapNodeExpansion Capability = "nodeExpansion" // support volume expansion for node | |||
| CapVolumeLimits = "volumeLimits" // support volume limits (can be *very* slow) | |||
| CapVolumeLimits Capability = "volumeLimits" // support volume limits (can be *very* slow) | |||
| CapSingleNodeVolume Capability = "singleNodeVolume" // support volume that can run on single node (like hostpath) | |||
There was a problem hiding this comment.
That can only run on a single node, right?
A network-attached storage system also provides volumes that "can run on a single node"...
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 6, 2019
…-upstream-release-1.15 Automated cherry pick of #82678: skip e2e tests that run on multi node cluster and require
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 6, 2019
…-upstream-release-1.16 Automated cherry pick of #82678: skip e2e tests that run on multi node cluster and require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/sig storage
What this PR does / why we need it:
Skip e2e tests that run on multi node cluster and require node independent volume for the drivers that don't support node independent volumes, like hostpath.
Which issue(s) this PR fixes:
Fixes #82675
Special notes for your reviewer:
I added a new capability as
CapNodeIndependentVolumeand set this true all csi and in tree test drivers other than hostpath, local and emptydir.Currently we need to make these tests off for only csi hostpath driver's tests, I'm open to a more simple solution.
cc @msau42
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: