Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: graduate ResourceQuotaScopeSelectors to GA - part2 #82690

Conversation

draveness
Copy link
Contributor

@draveness draveness commented Sep 13, 2019

/kind feature
/sig scheduling
/priority important-soon

What this PR does / why we need it:

Graduate ResourceQuotaScopeSelectors to GA

Which issue(s) this PR fixes:

ref: #82480

Does this PR introduce a user-facing change?:

The ResourceQuotaScopeSelectors feature has graduated to GA. The `ResourceQuotaScopeSelectors` feature gate is now unconditionally enabled and will be removed in 1.18.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20190409-resource-quota-ga.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2019
@draveness draveness changed the title [WIP] feat: graduate ResourceQuotaScopeSelectors to GA - part3 feat: graduate ResourceQuotaScopeSelectors to GA - part3 Nov 13, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2019
@draveness draveness changed the title feat: graduate ResourceQuotaScopeSelectors to GA - part3 feat: graduate ResourceQuotaScopeSelectors to GA - part2 Nov 13, 2019
@draveness draveness force-pushed the feature/graduate-ResourceQuotaScopeSelectors-to-ga branch from cc59ff0 to 9e92ee2 Compare November 13, 2019 03:13
@draveness
Copy link
Contributor Author

/assign @liggitt @ravisantoshgudimetla

Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the PR @draveness

/cc @ahg-g

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@liggitt
Copy link
Member

liggitt commented Nov 13, 2019

Remove all instances of checking ...Enabled(...ResourceQuotaScopeSelectors) and assume the result is true. This means you can drop any code that only ran when the feature was disabled, like the code in the strategy fields that gated population of that field (and associated unit test)

@draveness draveness force-pushed the feature/graduate-ResourceQuotaScopeSelectors-to-ga branch from 9e92ee2 to 271be24 Compare November 13, 2019 04:36
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2019
@draveness draveness force-pushed the feature/graduate-ResourceQuotaScopeSelectors-to-ga branch from 271be24 to 5cb9226 Compare November 13, 2019 06:07
@draveness
Copy link
Contributor Author

Remove all instances of checking ...Enabled(...ResourceQuotaScopeSelectors) and assume the result is true. This means you can drop any code that only ran when the feature was disabled, like the code in the strategy fields that gated population of that field (and associated unit test)

Thanks, Jordan. I have addressed the comments

@liggitt
Copy link
Member

liggitt commented Nov 13, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit b32a3d9 into kubernetes:master Nov 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 13, 2019
@draveness draveness deleted the feature/graduate-ResourceQuotaScopeSelectors-to-ga branch November 14, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants