Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference cherry pick process in hack script #82758

Merged
merged 1 commit into from Sep 17, 2019
Merged

reference cherry pick process in hack script #82758

merged 1 commit into from Sep 17, 2019

Conversation

tpepper
Copy link
Member

@tpepper tpepper commented Sep 16, 2019

The documentation on the cherry pick process has seen improvements
lately, but that isn't highly discoverable. This commit attempts to
make that information more visible.

Signed-off-by: Tim Pepper tpepper@vmware.com

/kind cleanup

NONE

/area release-eng

reference cherry pick process in hack script
a44ea7c 
The documentation on the cherry pick process has seen improvements
lately, but that isn't highly discoverable.  This commit attempts to
make that information more visible.

Signed-off-by: Tim Pepper <tpepper@vmware.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 16, 2019
@tpepper
Copy link
Member Author

tpepper commented Sep 16, 2019

/sig release

This PR is in response to review comments in kubernetes/community#4081

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 16, 2019
@tpepper tpepper mentioned this pull request Sep 16, 2019
Merged
@liggitt
Copy link
Member

liggitt commented Sep 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit ce1f0c3 into kubernetes:master Sep 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@nikopen nikopen Awaiting requested review from nikopen

@lavalamp lavalamp Awaiting requested review from lavalamp

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tpepper @liggitt @k8s-ci-robot