Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using short flags instead of validate #83117

Merged
merged 1 commit into from
Sep 29, 2019
Merged

using short flags instead of validate #83117

merged 1 commit into from
Sep 29, 2019

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Sep 25, 2019 •
edited

What type of PR is this?
/kind bug
/kind flake

What this PR does / why we need it:

using sudo -v instead of sudo --validate backward compatibility.
Which issue(s) this PR fixes:

Fixes #83115

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

using short flags instead with validate
11746bc 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 25, 2019
@zouyee
Copy link
Member Author

zouyee commented Sep 25, 2019

/cc @oomichi @odinuge

@zouyee
Copy link
Member Author

zouyee commented Sep 26, 2019

/retest

@zouyee
Copy link
Member Author

zouyee commented Sep 28, 2019

/cc @fejta

@zouyee
Copy link
Member Author

zouyee commented Sep 29, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 29, 2019
@zouyee
Copy link
Member Author

zouyee commented Sep 29, 2019

/cc @liggitt

fejta
fejta reviewed Sep 29, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7066107 into kubernetes:master Sep 29, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 29, 2019
@zouyee zouyee deleted the valid branch September 30, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@dashpole dashpole Awaiting requested review from dashpole

@lavalamp lavalamp Awaiting requested review from lavalamp

@oomichi oomichi Awaiting requested review from oomichi

@odinuge odinuge Awaiting requested review from odinuge

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

sudo --validate failed
3 participants
@zouyee @k8s-ci-robot @fejta