Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #83027:Update go mod hcsshim version to fix the kube-proxy issue cannot acce… #83198

Conversation

wawa0210
Copy link
Contributor

@wawa0210 wawa0210 commented Sep 26, 2019

Cherry pick of #83027 on release-1.15.

#83027: Update go mod hcsshim version to fix the kube-proxy issue cannot access service by self nodeip:port on windows

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix the kube-proxy issue cannot access service by self nodeip:port on windows

Which issue(s) this PR fixes:
Fixes #79515

Does this PR introduce a user-facing change?:

Fixes kube-proxy bug accessing self nodeip:port on windows

/sig network windows

@feiskyer @liggitt @BenTheElder @PatrickLang @dims

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Sep 26, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wawa0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Sep 26, 2019
@k8s-ci-robot k8s-ci-robot requested review from lavalamp, liggitt and a team September 26, 2019 14:12
@wawa0210
Copy link
Contributor Author

wawa0210 commented Sep 26, 2019

/assign @thockin @liggitt

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 26, 2019
@tpepper
Copy link
Member

tpepper commented Sep 27, 2019

/priority important-soon
/ok-to-test

@wawa0210 can you edit this PR's description to include the same note from #83027 as per https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md.

Also please in the future use the lastest https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh for cherry picks to insure the most up to date automation is creating the PR.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2019
@wawa0210
Copy link
Contributor Author

/priority important-soon
/ok-to-test

@wawa0210 can you edit this PR's description to include the same note from #83027 as per https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md.

Also please in the future use the lastest https://github.com/kubernetes/kubernetes/blob/master/hack/cherry_pick_pull.sh for cherry picks to insure the most up to date automation is creating the PR.

Thx, The note has been modified as per your suggestion

@PatrickLang PatrickLang added this to Backlog in SIG-Windows Oct 7, 2019
@PatrickLang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019
@liggitt
Copy link
Member

liggitt commented Oct 11, 2019

/approve
for vendoring

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, PatrickLang, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 364e31b into kubernetes:release-1.15 Oct 11, 2019
SIG-Windows automation moved this from Backlog to Done (v1.17) Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants